Skip to content

fix: Use correct service for StatefulSet #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented May 9, 2025

Description

The StatefulSet should use the headless service and not the group listener service. If the headless service is not used, the logs cannot be retrieved from within the airflow UI:

The upper part of the screenshot shows the listener service being used, and the lower part the (correct) headless service:

image (11)

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Roadmap has been updated

@adwk67 adwk67 added the type/bug label May 9, 2025
@adwk67 adwk67 marked this pull request as ready for review May 9, 2025 11:15
@adwk67 adwk67 moved this to Development: Waiting for Review in Stackable Engineering May 12, 2025
@adwk67 adwk67 self-assigned this May 12, 2025
@adwk67 adwk67 changed the title fix: Use correct service for sts fix: Use correct service for StatefulSet May 12, 2025
@adwk67 adwk67 requested a review from a team May 21, 2025 09:53
@sbernauer sbernauer requested a review from nightkr May 26, 2025 07:22
@@ -1170,7 +1170,7 @@ fn build_server_rolegroup_statefulset(
match_labels: Some(statefulset_match_labels.into()),
..LabelSelector::default()
},
service_name: Some(rolegroup_ref.object_name()),
service_name: Some(format!("{name}-metrics", name = rolegroup_ref.object_name())),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, is there a more authoritative source for the service name (eg: a function, in case it is needed in multiple places)?

Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering May 30, 2025
@sbernauer
Copy link
Member

As already mentioned I don't really like abusing the metrics service for this. Instead we should create a fresh headless service meant for this.
You mentioned in a daily that the Airflow 3 PR will do this properly, did I recall that correctly? Should we wait for that instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Development: In Review
Development

Successfully merging this pull request may close these issues.

3 participants