-
-
Notifications
You must be signed in to change notification settings - Fork 2
fix: Use correct service for StatefulSet #626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@@ -1170,7 +1170,7 @@ fn build_server_rolegroup_statefulset( | |||
match_labels: Some(statefulset_match_labels.into()), | |||
..LabelSelector::default() | |||
}, | |||
service_name: Some(rolegroup_ref.object_name()), | |||
service_name: Some(format!("{name}-metrics", name = rolegroup_ref.object_name())), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, is there a more authoritative source for the service name (eg: a function, in case it is needed in multiple places)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As already mentioned I don't really like abusing the metrics service for this. Instead we should create a fresh headless service meant for this. |
Description
The StatefulSet should use the headless service and not the group listener service. If the headless service is not used, the logs cannot be retrieved from within the airflow UI:
The upper part of the screenshot shows the listener service being used, and the lower part the (correct) headless service:
Definition of Done Checklist
Author
Reviewer
Acceptance