fix: Use correct service for StatefulSet #626
Closed
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adwk67
changed the title
| @@ -1170,7 +1170,7 @@ fn build_server_rolegroup_statefulset( | |||
| match_labels: Some(statefulset_match_labels.into()), | |||
| ..LabelSelector::default() | |||
| }, | |||
| service_name: Some(rolegroup_ref.object_name()), | |||
| service_name: Some(format!("{name}-metrics", name = rolegroup_ref.object_name())), | |||
There was a problem hiding this comment.
Just curious, is there a more authoritative source for the service name (eg: a function, in case it is needed in multiple places)?
NickLarsenNZ
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
|
As already mentioned I don't really like abusing the metrics service for this. Instead we should create a fresh headless service meant for this. |
|
Closing this without merging as the bugfix was included in this PR (so that the logs are retrievable). We can consider how to tackle this in the medium-term in the context of https://github.com/stackabletech/decisions/issues/54. |
adwk67
moved this from Development: In Review
to Development: Done
in Stackable Engineering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The StatefulSet should use the headless service and not the group listener service. If the headless service is not used, the logs cannot be retrieved from within the airflow UI:
The upper part of the screenshot shows the listener service being used, and the lower part the (correct) headless service:
Definition of Done Checklist
Author
Reviewer
Acceptance